blockchain/vm: bn256 gas cost change (eip1108) #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomee1313
requested review from
aidan-kwon,
ehnuje,
KimKyungup and
joowon-byun
as code owners
ehnuje
previously approved these changes
Jun 4, 2021
KimKyungup
previously approved these changes
Jun 4, 2021
There was a problem hiding this comment.
LGTM .
I think you can make some unit test for checking used gas. @yoomee1313
yoomee1313
dismissed stale reviews from KimKyungup, ehnuje, and aidan-kwon
via
1a921ad
|
@KimKyungup |
aidan-kwon
reviewed
Jun 8, 2021
aidan-kwon
reviewed
Jun 8, 2021
yoomee1313
force-pushed
the
bn128-gascost-change-eip1108
branch
from
1a921ad
to
121ea5d
Compare
aidan-kwon
approved these changes
Jun 9, 2021
|
@KimKyungup @ehnuje please take a look when you have a time |
KimKyungup
reviewed
Jun 11, 2021
KimKyungup
approved these changes
Jun 11, 2021
|
@yoomee1313 Let's merge this PR. |
ehnuje
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
core/vm/contracts.goandparams/protocol_params.goare referenced.computationCostconcept, so bn256 computationCost need to be revised too. However, eip1108's purpose is to reflect the performance improvement by adopting cloudflare library, but klaytn already have this library beforecomputationCostconcept is introduced. So, computationCost is not revised at here.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...