-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockchain/vm: sstore gas cost change (eip2200) #996
Conversation
@yoomee1313 If you reference the associated Ethereum PR, it would be nicer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoomee1313 Geth added one more PR on this change ethereum/go-ethereum#21605 .
Will you apply it later or it is not needed for the next version?
@aidan-kwon oh.. thanks for letting me know about 21605 PR. It is not needed for the next version.. However, in case of bringing berlin hardfork in future, i'll apply it. |
4bfbceb
Proposed changes
gas metering
function. Ethereum tried to upgrade sstore gas cost function at constantinople, but it was not successful. However, eip2200 did it successfully, and it is included in istanbul.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...