Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Kafka message #998

Merged

Conversation

jeongkyun-oh
Copy link
Contributor

@jeongkyun-oh jeongkyun-oh commented Jun 27, 2021

Proposed changes

  • In order not to mix the messages from multi-producers, the message format is updated.
  • Introduced version/producerId for the message
    • the version is added for backward-compatibility so that the old message production and consumption should work as normal.
    • the producerId is added to distinguish the messages with the same key, but from different data source.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@jeongkyun-oh jeongkyun-oh force-pushed the KLT-893-update-kafka-message-key branch from d7bd919 to c56ec05 Compare June 27, 2021 23:47
@jeongkyun-oh jeongkyun-oh force-pushed the KLT-893-update-kafka-message-key branch from 8659690 to 120f65d Compare June 28, 2021 08:25
aidan-kwon
aidan-kwon previously approved these changes Jun 28, 2021
Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yoomee1313
yoomee1313 previously approved these changes Jun 29, 2021
Copy link
Contributor

@yoomee1313 yoomee1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

datasync/chaindatafetcher/kafka/config.go Show resolved Hide resolved
Copy link
Contributor

@hyochan-brown hyochan-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have a few questions!

datasync/chaindatafetcher/kafka/consumer.go Outdated Show resolved Hide resolved
datasync/chaindatafetcher/kafka/consumer.go Show resolved Hide resolved
@jeongkyun-oh jeongkyun-oh merged commit 7fdb84b into klaytn:dev Jun 30, 2021
@jeongkyun-oh jeongkyun-oh deleted the KLT-893-update-kafka-message-key branch June 30, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants