Support references to record fields in annotated functions #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalt
commented
Aug 6, 2019
src/test/resources/org/elm/lang/core/parser/fixtures/partial/FieldAccessors.txt
Show resolved
Hide resolved
klazuka
reviewed
Aug 7, 2019
src/main/kotlin/org/elm/lang/core/psi/elements/ElmFieldAccessorFunctionExpr.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows features such as Go To Definition, Rename, Quick Documentation, and Find Usages to work on record fields. This works for records defined in either type aliases or type annotations. It should work for all field names inside of a top-level annotated function, including within nested functions. This includes field access expressions, field accessor functions, and record value expressions that get assigned to a type alias or union.
Only references to unions and type aliases will resolve. Field access of record literals, either in the same function or in another unannotated function, will not resolve. Field access on the parameters of unannotated top-level functions will not resolve.
As part of this change, I removed the pin from the field access expression bnf rule so that the name element is always present. This causes error messages to be slightly more cryptic in some cases, but it also fixes the incorrect parsing of expressions like
a .b.