Reduce stubs boilerplate #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalt
approved these changes
Aug 8, 2019
| @@ -72,12 +73,106 @@ fun <T : PsiElement> PsiElement.parentOfType(vararg classes: KClass<out T>): T? | |||
| inline fun <reified T : PsiElement> PsiElement.contextOfType(strict: Boolean = true): T? = | |||
| PsiTreeUtil.getContextOfType(this, T::class.java, strict) | |||
|
|
|||
| inline fun <reified T : PsiElement> PsiElement.childOfType(strict: Boolean = true): T? = | |||
| PsiTreeUtil.findChildOfType(this, T::class.java, strict) | |||
| inline fun <reified T : PsiElement> PsiElement.descendantOfType(): T? = | |||
There was a problem hiding this comment.
Love this rename; I've had to look through the source code multiple times to remember whether this was only direct children or not.
There was a problem hiding this comment.
I know, I can't believe that they have built so much code on such poor naming conventions. There were undoubtedly a lot of bugs along the way.
| } | ||
| } | ||
|
|
||
| inline fun <reified T : PsiElement> PsiElement.stubDescendantsOfTypeStrict(): Collection<T> = |
There was a problem hiding this comment.
Maybe use a strict parameter rather than separate functions for the strict case? It's fine either way.
There was a problem hiding this comment.
I copied this straight from intellij-rust. I don't have a preference either, at least not yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last night I started looking at putting type annotations into the stub system, but it was going to require a ton of boilerplate. Luckily intellij-rust has already dealt with the problem. This should make it a little bit easier to do.