-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have Ubuntu systems fall back to build scripts for "Debian" if there isn't an "ubuntu" variant available. #1700
Comments
@sp1ff Thanks for opening this issue. Here are my thoughts on this one: For developing and testing KLEE under different setups (LLVM versions, LLVM configurations, ... ), the script is useful. Let me know if anything is unclear. |
Thanks, @MartinNowack. Definitely agree that the distribution-specific package is preferable for casual users. |
The basic idea of the script is to try from the most specific instructions to the least specific instructions until one matching file is found, i.e The script will first try:
We are currently not really using the "version" part, Instead, one could detect
(I'm just ignoring the fact of which distribution is a variant of another for the simplicity of this discussion.) Hence, we might get away with just detecting the right OS/distribution and propagating them as part of the file structure. Let me know what your thoughts are. |
Ah, I see. So my idea was that the "debian" file would contain things that applied to Debian and all Debian-derived distros. In other words, it could be picked-up on Ubuntu and Mint, for example. Hence the "most-derived" distribution name would not be a part of the file name.
Whereas on Mint, it would be:
Notice that |
Is your feature request related to a problem? Please describe.
I find myself specializing the build for Debian by just copying the Ubuntu files verbatim to files named
p-$COMPONENT-linux-debian.inc
. This works because Ubuntu & Debian share the same package manager (apt
), but at the cost of replicating code.Describe the solution you'd like
Update
execution_action()
to, on failure to findp-${component}-${OS}-${DISTRIBUTION}-${DISTRIBUTION_VER}.inc
orp-${component}-${OS}-${DISTRIBUTION}.inc
, check for a Debian variant, IFF ${DISTRIBUTION} = "Ubuntu". We should consider generalizing this: Mandrake could fall-back to Red Hat, Manjaro to Arch & so forth.If this is of interest, I'd be happy to cut the PR myself.
The text was updated successfully, but these errors were encountered: