Fixed a bug with how non power 2 types were written to memory #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to fix a bug which manifests itself in the following two snippets:
This one works on the current master if pragma pack(1) is removed:
What happens is that in these cases w = 24, which makes it jump to Int8 case in the switch(w), which causes the wrong value to be stored. I've added a check to make sure that w is a power of 2, so it definitively fits into one of the switch cases and uses the slow version in all the others.
I think this is a better option than adding Int24 into the switch since then all the others are also needed.