Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation for command line argument link-llvm-lib #1204

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

MartinNowack
Copy link
Contributor

Currently, arbitrary *.bc files or archives containing .bc files (.bca or .a) can
be linked using --link-llvm-lib. Change documentation of command line argument to make this clear.

This feature is useful to keep avoid linking the bitcode libraries with the application as bitcode file in the first place.

Fix error message in case library could not be loaded.

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #1204 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   67.91%   67.91%           
=======================================
  Files         155      155           
  Lines       17493    17493           
  Branches     4039     4039           
=======================================
  Hits        11881    11881           
  Misses       3777     3777           
  Partials     1835     1835
Impacted Files Coverage Δ
tools/klee/main.cpp 65.53% <50%> (ø) ⬆️

@ccadar
Copy link
Contributor

ccadar commented Jan 13, 2020

Thanks, @MartinNowack , we've received a couple of queries about this, so it's nice to improve the documentation.
Minor: should we say (.bca, .bc, .a) instead of (e.g., .bca, .bc)?

Currently, arbitrary *.bc files or archives containing .bc files (.bca or .a) can
be linked using `--link-llvm-lib`. Change documentation of command line argument to make this clear.

This feature is useful to keep avoid linking the bitcode libraries with the application as bitcode file in the first place.

Fix error message in case library could not be loaded
@ccadar ccadar merged commit 6eafad4 into klee:master Jan 17, 2020
@MartinNowack MartinNowack deleted the fix_libloading_documentation branch January 17, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants