Handle global variables #1271
Merged
Handle global variables #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
+ Coverage 69.06% 69.08% +0.02%
==========================================
Files 154 154
Lines 18204 18207 +3
Branches 4042 4043 +1
==========================================
+ Hits 12572 12578 +6
+ Misses 3888 3886 -2
+ Partials 1744 1743 -1
|
5 tasks
MartinNowack
force-pushed
the
handle_global_variables
branch
from
f46f59c
to
e51a5c7
Compare
Global variables can't be a direct call target. Their values are read and treated as indirect call targets.
MartinNowack
force-pushed
the
handle_global_variables
branch
from
e51a5c7
to
c9abbf3
Compare
|
@ccadar The test case finally reflects the problem, which can be seen in the increased coverage. |
|
@MartinNowack excellent! And thanks again, that's an important fix! |
ccadar
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global variables were not handled correctly while validating direct call targets.
This lead to crashes of KLEE.
This PR adds this case to handle direct call targets.