Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FD_Fail test in nix sandbox #1471

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Jan 29, 2022

Summary:

/etc/mtab doesn't exist in the Nix build sandbox since /etc doesn't
exist. However, /dev/zero is more common on UNIX systems and does.

Checklist:

  • The PR addresses a single issue. If it can be divided into multiple independent PRs, please do so.
  • The PR is divided into a logical sequence of commits OR a single commit is sufficient.
  • There are no unnecessary commits (e.g. commits fixing issues in a previous commit in the same PR).
  • Each commit has a meaningful message documenting what it does.
  • All messages added to the codebase, all comments, as well as commit messages are spellchecked.
  • The code is commented OR not applicable/necessary.
  • The patch is formatted via clang-format OR not applicable (if explicitly overridden leave unchecked and explain).
  • There are test cases for the code you added or modified OR no such test cases are required.

ccadar
ccadar previously approved these changes Mar 9, 2022
@ccadar
Copy link
Contributor

ccadar commented Mar 9, 2022

@numinit sorry for the delay on merging this. The patch is fine, but could you please rebase it and push it again, as I'm not sure why the CI didn't get triggered properly. Thanks!

/etc/mtab doesn't exist in the Nix build sandbox since /etc doesn't
exist. However, /dev/zero is more common on UNIX systems and does.
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #1471 (53af6a5) into master (ec81fd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files         155      155           
  Lines       18481    18481           
  Branches     4100     4100           
=======================================
  Hits        12818    12818           
  Misses       3886     3886           
  Partials     1777     1777           

Copy link
Contributor

@ccadar ccadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @numinit

@ccadar ccadar merged commit 043f43f into klee:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants