Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some leaks in klee-replay #1550

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fixed some leaks in klee-replay #1550

merged 1 commit into from
Dec 9, 2022

Conversation

ccadar
Copy link
Contributor

@ccadar ccadar commented Sep 24, 2022

Summary:

These fixes some leaks in klee-replay reported in #1512.
While these particular leaks are not important, we should get to a stage where LSan & ASan runs pass.

Checklist:

  • The PR addresses a single issue. If it can be divided into multiple independent PRs, please do so.
  • The PR is divided into a logical sequence of commits OR a single commit is sufficient.
  • There are no unnecessary commits (e.g. commits fixing issues in a previous commit in the same PR).
  • Each commit has a meaningful message documenting what it does.
  • All messages added to the codebase, all comments, as well as commit messages are spellchecked.
  • The code is commented OR not applicable/necessary.
  • The patch is formatted via clang-format OR not applicable (if explicitly overridden leave unchecked and explain).
  • There are test cases for the code you added or modified OR no such test cases are required.

@ccadar
Copy link
Contributor Author

ccadar commented Sep 24, 2022

Coverage upload fails for some reason, but those are not required checks.

@ccadar ccadar mentioned this pull request Sep 25, 2022
8 tasks
@MartinNowack
Copy link
Contributor

@ccadar Can you remove the line in: https://github.com/klee/klee/blob/master/utils/sanitizers/lsan.txt to not ignore this leak anymore?

@ccadar
Copy link
Contributor Author

ccadar commented Sep 26, 2022

@MartinNowack Unfortunately, there is still one leak remaining in there, which is uglier to fix. So we can't remove that line in this PR...

Copy link
Contributor

@MartinNowack MartinNowack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's merge this for now and try to fix the remaining issues in a later PR. Thanks @ccadar

@MartinNowack MartinNowack merged commit f11aae6 into klee:master Dec 9, 2022
@ccadar ccadar deleted the leaks branch March 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants