Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-bout tool to generate ktest file using concrete arguments and files #956

Merged
merged 1 commit into from
Oct 26, 2018
Merged

gen-bout tool to generate ktest file using concrete arguments and files #956

merged 1 commit into from
Oct 26, 2018

Conversation

domainexpert
Copy link
Contributor

Whereas gen-random-bout produces ktest file file.bout with random content, gen-bout produces file.bout with specific content specified by the user.

  • Sample use cases:
    • Using an interesting input as a seed.
    • Analyzing the path condition of a concrete input.
  • Also added the test: test/Runtime/POSIX/GenBout.c.

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #956 into master will increase coverage by 0.34%.
The diff coverage is 66.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage   66.04%   66.39%   +0.34%     
==========================================
  Files         142      143       +1     
  Lines       16188    16339     +151     
  Branches     3747     3775      +28     
==========================================
+ Hits        10692    10848     +156     
+ Misses       3813     3792      -21     
- Partials     1683     1699      +16
Flag Coverage Δ
#systemtests_unittests 66.39% <66.88%> (+0.34%) ⬆️
Impacted Files Coverage Δ
tools/gen-bout/gen-bout.cpp 66.88% <66.88%> (ø)
tools/klee-replay/klee-replay.c 26.36% <0%> (+0.45%) ⬆️
tools/klee-replay/file-creator.c 25.61% <0%> (+8.77%) ⬆️
runtime/POSIX/fd_init.c 79.71% <0%> (+13.04%) ⬆️
runtime/POSIX/klee_init_env.c 52.34% <0%> (+15.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916b72a...84902f6. Read the comment docs.

}

if (file_counter > 0) {
// KLEE assumes that -sym-files is specified only once, and the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is outdated now, since we changed KLEE to only accept one sym-files option

@ccadar
Copy link
Contributor

ccadar commented Oct 16, 2018

Hi @domainexpert, the recent thread on klee-dev reminded me about this PR. Since it's a new independent tool, I'm happy to merge it quickly. I left just one quick comment about an outdated comment.

Ideally, the tool would support multiple sym-file arguments, but I guess we can leave this as future work.

…d concrete arguments and files.

* Sample use cases:
  * Using an interesting input as a seed, such as a crashing input.
  * Analyzing the path condition of a crashing input.
* Also added the test: test/Runtime/POSIX/GenBout.c
@domainexpert
Copy link
Contributor Author

@ccadar Thank you for the review. I had removed the comment.

@ccadar
Copy link
Contributor

ccadar commented Oct 26, 2018

Thanks, @domainexpert, I'll merge it now.

@ccadar ccadar merged commit be34078 into klee:master Oct 26, 2018
@domainexpert domainexpert deleted the gen-bout branch October 30, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants