Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/clean #49

Merged
merged 3 commits into from
Jan 3, 2019
Merged

Feature/clean #49

merged 3 commits into from
Jan 3, 2019

Conversation

andreasonny83
Copy link
Contributor

@andreasonny83 andreasonny83 commented Sep 16, 2016

Introducing a clean option to force remove all the files listed in the template file, if any

@ptitgraig
Copy link
Collaborator

Hello, thanks for this PR. What would be the use case for such an option ?

@andreasonny83
Copy link
Contributor Author

I'm using that option to turn on and off a mock service to inject inside my Web application while running on development mode. When I 'grunt build', instead, I want to have my app working against a real API so, using clean, I can easily avoid injecting that service inside my index.html file and I can avoid having 2 different index.html files: one for development and the other for prodction

@p3x-robot
Copy link
Collaborator

ok so it is safe to merge it? i am open to merge it for you and thank you very much. the original creator was not working on it and i just found access right now, i still use this package... so i maintain it.

@p3x-robot
Copy link
Collaborator

it says there is conflicting file.

@andreasonny83
Copy link
Contributor Author

Wow, that's cool. I opened this PR more than 2 years ago.
I fixed the conflicts by the way so feel free to merge that in if you want.
Thanks.

@p3x-robot
Copy link
Collaborator

i merged it, but @klei has not provided me access to publish to the npm, so a bit it will take some time.

@p3x-robot p3x-robot merged commit 4a3d060 into klei:master Jan 3, 2019
@andreasonny83 andreasonny83 deleted the feature/clean branch January 3, 2019 22:35
@ptitgraig
Copy link
Collaborator

I can publish to npm and will do shortly.

@p3x-robot
Copy link
Collaborator

that would be quite cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants