Follow Symfony naming convention when naming roles

kleijnweb · Feb 7, 2017 · 1f18305 · 1f18305
1 parent ea78cf8
commit 1f18305
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Authenticator/Authenticator.php b/src/Authenticator/Authenticator.php
@@ -135,10 +135,10 @@ public function setUserRolesFromAudienceClaims(UserInterface $user, TokenInterfa
             if ($claimKey === 'aud') {
                 if (is_array($claimValue)) {
                     foreach ($claimValue as $role) {
-                        $user->addRole($role);
+                        $user->addRole("ROLE_" . strtoupper($role));
                     }
                 } elseif (is_string($claimValue)) {
-                    $user->addRole($claimValue);
+                    $user->addRole("ROLE_" . strtoupper($claimValue));
                 }
             }
         }

diff --git a/src/Tests/Authenticator/AuthenticatorTest.php b/src/Tests/Authenticator/AuthenticatorTest.php
@@ -205,11 +205,11 @@ public function willAddRolesFromAudienceClaimsInToken()
 
         $user->expects($this->once())
             ->method('addRole')
-            ->with('guests');
+            ->with('ROLE_GUESTS');
 
         $user->expects($this->once())
             ->method('getRoles')
-            ->willReturn(['guests']);
+            ->willReturn(['ROLE_GUESTS']);
 
         $authenticator->authenticateToken($anonToken, $userProvider, 'myprovider');
     }