This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Add support for invokable controllers #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2018 17:37
Tests don't need to be loaded during use. Also, autoload-dev is how PhpStorm determines what directory holds the tests.
nesl247
changed the title
|
I agree. Feel free to rename. If you run a PSR2 check (I saw at least 1 misplaced brace), I would be happy to merge this. Thanks :) |
|
There's actually a few PSR-2 style issues outside of the scope of this PR as well. I advise adding php-cs-fixer into the project and including that in CI. I'm making the fixes to the code I touched. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for invokable controllers.
I'm not happy with the
invokablename being part of the route name though. I wanted to open this up so it could be discussed. Maybeactionwould be better as this pattern is known as ADR (Action/Domain/Responder)?Closes #2.