This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Changed isRequired to cannotBeEmpty for cache key. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2018 18:05
KernelTestClass now requires KERNEL_CLASS instead of a hardcoded kernel name with KERNEL_DIR. I left the KERNEL_DIR env var in phpunit as anyone who may be using an older version locally would have that instead. I'm not sure if the namespace change will have broken it though. The other way to fix this is to add a files section and load the kernel that way, and then the namespace stuff could be undone.
|
@nesl247 So I made some changes to this to make it work from 2.8+ all the way up to 4. Travis is supposed to run the tests against the newest upstream package versions. Not sure what went wrong there, looking into it. |
|
I dunno. I had immediately thought that maybe travis was caching the composer.lock that would be auto-generated, but then I noticed you used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #113
In order to get the tests to pass locally, there were some changes that needed to be made. I fixed the test files being loaded in the non-dev autoloader, and also fixed the issue with symfony 4's KernelTestCase.
See the commit messages themselves for more details.