Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks do not reflect recommended usage #133

Open
adriangb opened this issue Jan 22, 2022 · 1 comment
Open

benchmarks do not reflect recommended usage #133

adriangb opened this issue Jan 22, 2022 · 1 comment

Comments

@adriangb
Copy link

adriangb commented Jan 22, 2022

Several frameworks's apps are written in a manner that does not reflect the usage suggested in their docs.

For example, the FastAPI documentation suggests using File() to have files extracted from forms and injected: https://fastapi.tiangolo.com/tutorial/request-files/. But in the benchmarks the Request.form is used just like in Starlette. This is obviously going to be faster, but then it's not using any of the features the framework provides on top of Starlette. If that's what users were doing, they'd be using Starlette.

I suggest that the apps get restructured to better reflect the documented usage of each framework. That is much more useful to users (and framework developers) and would help highlight issues like tiangolo/fastapi#4187

@adriangb adriangb changed the title benchmarks do not reflect recommended usage of framewotkd benchmarks do not reflect recommended usage Jan 22, 2022
@adriangb
Copy link
Author

@klen are you open to this? I'm happy to submit PRs, but I don't want it to seem like I am unilaterally trying to hamper specific web frameworks in the benchmarks, so I won't do anything without your explicit approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant