Rename async to async_mode for python 3.7 compatibility #120
Conversation
You can't rely on tox alone to test the various versions of python because they might not be installed. Instead specify a build matrix by hand. This also allows for a cleaner after_script for coveralls.
This correctly parses options of the form "E302,W405", which before this was split into individual characters. This resulted in all errors and/or being considered when ignoring/selecting. Since specifying just "E" disables all errors, having a list of characters meant that it always encountered an individual "E" and thus disabled all errors.
Python 3.7 will be released in about 2 months.[1] It also introduces `async` as a reserved keyword which is currently used by pylama as a module, variable, and option name. This also removes python 3.3 from `.travis.yml`. Python 3.3 reached its end of life at 2017-09-29.[2] Without `py33` specified in `tox.ini` the tests fail anyway. [1] https://www.python.org/dev/peps/pep-0537/#schedule [2] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
Fixes W606 'async' and 'await' are reserved keywords starting with Python 3.7 This continues to accept `--async` as an argument and `async = 1` in config files. Therefore this commit should not be breaking.
|
@klen Can you please merge and release this? Python 3.7 will be released at the end of this month, see https://www.python.org/dev/peps/pep-0537/#schedule. |
|
ping @klen |
|
Unfortunately pylama seems to be effectively unmaintained now. From what I've seen, issues/PRs/pings on this repo and some of the plugins haven't been getting any responses in almost a year. Python 3.7 incompatibility will probably be the nudge I needed to either fork and fix up a few things myself, or to switch to something else (possibly just running the checkers separately). |
|
ping @klen ! |
|
ping @klen |
|
@michael-k : python-mode uses this fork: https://github.com/fmv1992/pylama. Can you please publish your pull request there as well? |
|
AFAIK Klen does not maintain this project. python-mode uses my own branch because I can accept/review PRs in a timely way. If there are other more commited devs in this project we can change python-mode's pylama to it. |
|
Just wondering if anyone is considering alternatives? https://github.com/PyCQA/prospector seems a bit more lively. |
|
I have pulled the changes in this pull request into Pylava. Pylava is intended to be a community maintained fork of Pylama. It works with Python 3.7. Enter the following command to install Pylava: With Python 3, you may need to enter the following command instead: After that you need to use Thanks to @michael-k for this pull request. |
|
See #129 |
|
@michael-k Thank you for the work! |
This PR should not break backwards compatibility for anyone using pylama as a command line tool. It is however breaking for anyone importing from
pylama.asyncor relying on the existence ofoptions.async.Fixes #89
This PR is based on PR #112 by @maxnordlund and includes his commits.