Fix parsing of multi-options for pycodestyle #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
18664cf
to
e1efbe9
Compare
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
e1efbe9
to
e308003
Compare
|
The test failures are due to missing pythons: |
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
2 times, most recently
from
0870b74
to
eea05f4
Compare
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
60410fa
to
eea05f4
Compare
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
15a3d09
to
5bfe748
Compare
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
5bfe748
to
b2f5be5
Compare
You can't rely on tox alone to test the various versions of python because they might not be installed. Instead specify a build matrix by hand. This also allows for a cleaner after_script for coveralls.
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
b2f5be5
to
50b3562
Compare
|
This is blocked by #114 to make the tests green. Merging using rebase removes that commit, otherwise this needs to be rebased. |
Closed
|
Do we really need to check against python 3.3? Is there any OS in which python 3.3 is the default version? |
|
I'm not sure, but I didn't want to change that since it's currently in the testing matrix. But that should be in another PR, right? |
|
Ping @diraol how do we get this merged? |
This correctly parses options of the form "E302,W405", which before this was split into individual characters. This resulted in all errors and/or being considered when ignoring/selecting. Since specifying just "E" disables all errors, having a list of characters meant that it always encountered an individual "E" and thus disabled all errors.
maxnordlund
force-pushed
the
fix-pycodestyle-ignore
branch
from
50b3562
to
4c19d4c
Compare
|
@maxnordlund It is on the hands of @klen as far as I know. |
|
Any update? |
|
@maxnordlund Thank you for the PR. |
|
Np |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correctly parses options of the form "E302,W405", which before this was split into individual characters. This resulted in all errors and/or being considered when ignoring/selecting.
Since specifying just "E" disables all errors, having a list of characters meant that it always encountered an individual "E" and thus disabled all errors.