Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

feat: fetch minimal data and cache where possible #167

Merged
merged 2 commits into from Aug 13, 2018

Conversation

satello
Copy link
Contributor

@satello satello commented Aug 13, 2018

  • finding all open disputes in a session requires looping over the entire disputes array. Not getting voteCounters reduced the time from ~700ms/dispute to ~200ms/dispute.
  • Cache data used in fetching disputes (timestamps, open disputes, meta evidence)
  • Getting disputes table should be much faster but still relatively slow (~ 200ms * number of disputes + (2-9 seconds) * number of sessions juror was drawn + some extra time for http requests, draws, dispute created event).
  • Loading a dispute takes about 15 seconds.

@satello satello merged commit 0b8670f into develop Aug 13, 2018
@satello satello deleted the feat/cache_reused_session branch August 13, 2018 17:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 777

  • 6 of 40 (15.0%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 16.327%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/resources/Disputes.js 0 1 0.0%
src/contracts/implementations/arbitrable/Arbitrable.js 1 4 25.0%
src/utils/StoreProviderWrapper.js 1 4 25.0%
src/contracts/implementations/arbitrator/Kleros.js 4 31 12.9%
Files with Coverage Reduction New Missed Lines %
src/utils/StoreProviderWrapper.js 1 2.86%
src/resources/Disputes.js 1 5.26%
src/contracts/implementations/arbitrable/Arbitrable.js 2 5.26%
src/contracts/implementations/arbitrator/Kleros.js 5 2.45%
Totals Coverage Status
Change from base Build 770: -0.09%
Covered Lines: 201
Relevant Lines: 1001

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants