Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review by @nix1g #8

Closed
nix1g opened this issue Nov 2, 2020 · 0 comments · Fixed by #9
Closed

Review by @nix1g #8

nix1g opened this issue Nov 2, 2020 · 0 comments · Fixed by #9
Assignees
@nix1g
Labels
maintenance RAB process flow

Comments

@nix1g
Copy link
Contributor

nix1g commented Nov 2, 2020 •
edited
Loading

Linguo.sol Review @ 62e7de0

No major issues, working as intended.
Some gas optimization can be made, though it is not worth adding them at this point in development.

Suggestions

  1. maxPrice is underused and can be functionally replaced by requesterDeposit.
  2. Some require() can be done earlier to clarify code: L270, L361-L362, L418-L419, L544-L545.
  3. L548-L549 == true is unnecessary.

Questions

  1. Why is the reviewTimeout set globally? I'm not sure all translation works require the same amount of time to review.
@nix1g nix1g added the maintenance RAB process flow label Nov 2, 2020
@nix1g nix1g self-assigned this Nov 2, 2020
@nix1g nix1g mentioned this issue Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nix1g nix1g

Labels
maintenance RAB process flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore/RAB update following @nix1g's review
1 participant
@nix1g