Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless assignment #28

Closed
eccentricexit opened this issue Sep 25, 2020 · 1 comment
Closed

Remove useless assignment #28

eccentricexit opened this issue Sep 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@eccentricexit
Copy link
Contributor

tcr/contracts/GeneralizedTCR.sol

Line 312 in b45e9cc

round.feeRewards = round.feeRewards.subCap(arbitrationCost);

This line does nothing since feeRewards at that point is always zero.
@eccentricexit eccentricexit added the enhancement New feature or request label Sep 25, 2020
@eccentricexit eccentricexit changed the title Useless line Remove useless assignment Sep 25, 2020
@eccentricexit
Copy link
Contributor Author

This is wrong, feeRewards is assigned inside contribute>requestStatusChange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eccentricexit