Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Impl controller logic v1 #4

Merged
merged 3 commits into from
Jun 19, 2020
Merged

feat: Impl controller logic v1 #4

merged 3 commits into from
Jun 19, 2020

Conversation

simon-cj
Copy link
Contributor

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2020
gaocegege
gaocegege reviewed Jun 19, 2020
View reviewed changes
build/model-registry-controller/Dockerfile Outdated Show resolved Hide resolved
pkg/api/v1alpha1/modeljob_types.go Outdated Show resolved Hide resolved
pkg/controllers/modeljob_controller.go Outdated Show resolved Hide resolved
pkg/controllers/reconcile.go Show resolved Hide resolved
pkg/controllers/reconcile.go Outdated Show resolved Hide resolved
pkg/controllers/reconcile.go Show resolved Hide resolved
pkg/controllers/reconcile.go Outdated Show resolved Hide resolved
pkg/controllers/utils.go Show resolved Hide resolved
@simon-cj simon-cj mentioned this pull request Jun 19, 2020
Open
@gaocegege gaocegege mentioned this pull request Jun 19, 2020
Closed
@gaocegege
Copy link
Member

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@caicloud-bot caicloud-bot merged commit 4066990 into kleveross:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

Assignees

@gaocegege gaocegege

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simon-cj @gaocegege @caicloud-bot