Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support Model Conversion/Compression via CRD #23

Closed
gaocegege opened this issue Jun 4, 2020 · 11 comments
Closed

[feature] Support Model Conversion/Compression via CRD #23

gaocegege opened this issue Jun 4, 2020 · 11 comments
Assignees
Labels
priority/P2 Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@gaocegege
Copy link
Member

gaocegege commented Jun 4, 2020

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

We should support model conversion and compression. We can have a init container to pull the model from registry to local filesystem. Then we can use MMdnn or other tools to convert/compress the model, then we can push the new model with the unique tag or the desired tag.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

https://github.com/gaocegege/ormb/tree/modeljob

@gaocegege
Copy link
Member Author

BTW, we can use Harbor Webhooks to trigger model analyzer: https://goharbor.io/docs/2.0.0/working-with-projects/project-configuration/configure-webhooks/

@gaocegege
Copy link
Member Author

/priority p2

@caicloud-bot caicloud-bot added the priority/P2 Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 5, 2020
@gaocegege
Copy link
Member Author

/assign @simon-cj

@simon-cj currently has the bandwidth for it.

@ddysher
Copy link
Member

ddysher commented Jun 16, 2020

what's the status? @simon-cj

Can we have a WIP or design doc first? (e.g. I want to know why do we need CRD for this...)

@gaocegege
Copy link
Member Author

The CRD is to avoid self-maintained queue in the implementation.https://docs.google.com/document/d/1JyjCzpO0NrsIOK29i_b2vTPpYc6-ckNcCVquOCj2ooM/edit?ts=5ec22fe9#heading=h.6j6pdsfmko7y

@simon-cj
Copy link
Contributor

simon-cj commented Jun 16, 2020 via email

@ddysher
Copy link
Member

ddysher commented Jun 16, 2020

IIUC, the CRD design should be part of model-registry, not part of ormb. Are we going to create a new repository or work in ormb directly but create a new component?

The CRD is to avoid self-maintained queue in the implementation.https://docs.google.com/document/d/1JyjCzpO0NrsIOK29i_b2vTPpYc6-ckNcCVquOCj2ooM/edit?ts=5ec22fe9#heading=h.6j6pdsfmko7y

@gaocegege
Copy link
Member Author

Depends on the scope of ormb. We can discuss it on the meeting.

@simon-cj
Copy link
Contributor

simon-cj commented Jun 16, 2020 via email

@ddysher
Copy link
Member

ddysher commented Jun 16, 2020

LGTM

@simon-cj you are mixing Half-width & Full-width punctuation marks :)

CRD design doc is provided by gaocegege, recently, I‘am updating extrat and
convert python script and verify logic by ormb. so, the crd controller is
simple now, I will complete next.

@gaocegege
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P2 Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants