Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ormb-storage-initializer): Relayout model file for serving #110

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

simon-cj
Copy link
Contributor

@simon-cj simon-cj commented Aug 10, 2020

What this PR does / why we need it:

Add your description

  • For klever-model-registry, it use ormb-storage-initilizer to pull and export model before extract model, but can't move the model file to other location in model dir, so add reLayout option , if false, it will pull and export model only, won't move the model file.
    The reLayout default is true, it is for model inference.

  • When run model inference, if it is tensorflow_inference_server, must make the dir as:

--| modelRootPath
     -| 1/
       -| xxxx.pd

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @gaocegege

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2020
@gaocegege
Copy link
Member

Why do we need such a PR? Can you please explain it?

@simon-cj simon-cj force-pushed the update-clever-to-klever branch 3 times, most recently from 8957bf4 to 629f47f Compare August 10, 2020 12:14
@simon-cj
Copy link
Contributor Author

Why do we need such a PR? Can you please explain it?

Add some description, PTAL

@simon-cj
Copy link
Contributor Author

For up description, WDYT @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@caicloud-bot caicloud-bot merged commit 866be61 into kleveross:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants