Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update example model and remove relayout option #115

Merged
merged 1 commit into from
Aug 23, 2020
Merged

feat: Update example model and remove relayout option #115

merged 1 commit into from
Aug 23, 2020

Conversation

simon-cj
Copy link
Contributor

@simon-cj simon-cj commented Aug 21, 2020 •
edited

What this PR does / why we need it:

Add your description
For trtserver, all model format must have directory structure as follow when serving:

--| models
     --| config.pbtxt
     --| 1
        --| xxx.pb

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @gaocegege

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2020
gaocegege
gaocegege reviewed Aug 21, 2020
View reviewed changes
cmd/ormb-storage-initializer/cmd/pull-and-export.go Outdated
// For TensorFlow serving, MUST move /mnt/models/model to /mnt/models/1 (dstDir).
ormbfileBytes, err := ioutil.ReadFile(path.Join(modelDir, "ormbfile.yaml"))
if err != nil {
if err := os.Rename(originalDir, path.Join(modelDir, "1")); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep 1 in the model content layer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK. the directory structure will be as follow when ormb push:

--| models
    --| model
       --| 1
           --| xxx.pb
    --| ormbfile.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in this way we do not need to have this trick. As you know, other formats such as onnx do not need 1 dir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment are address, PTAL

@simon-cj simon-cj changed the title feat: Update re-layout logic for model serving feat: Update example model and remove relayout option Aug 23, 2020
gaocegege
gaocegege reviewed Aug 23, 2020
View reviewed changes
pkg/model/format.go Outdated Show resolved Hide resolved
@simon-cj simon-cj force-pushed the update-clever-to-klever branch 2 times, most recently from 1e9a7d5 to 11e35f3 Compare August 23, 2020 07:32
gaocegege
gaocegege approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2020
@gaocegege
Copy link
Member

Please repush to trigger another build. I decrease the CI test coverage threshold.

@caicloud-bot caicloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2020
@caicloud-bot
Copy link

New changes are detected. LGTM label has been removed.

@simon-cj simon-cj merged commit f657c35 into kleveross:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees

@gaocegege gaocegege

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simon-cj @caicloud-bot @gaocegege