Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributors file and add all contributors to about dialog #1249

Merged
merged 2 commits into from Mar 26, 2022

Conversation

kliment
Copy link
Owner

@kliment kliment commented Mar 14, 2022

It's about time to credit all the contributors to the Printrun project more prominently. I've added a CONTRIBUTORS.md file linkedf from README and added the list there into the credits dialog as well. Comments very welcome, also on whether there's a better way to format it.

@rockstorm101
Copy link
Collaborator

Hi @kliment, thank you for you effort on compiling this list. Much appreciated. My only comment would be that keeping two virtually identical lists is usually a pain and there's a high chance they get out of sync. Could we somehow make the list in the 'About' page to emanate from the one in contributors.md? Something along these lines in pronterface.py:

for each developer in contributors.md do
    info.AddDeveloper(developer)

This would also make pronterface.py less cluttered.

@kliment
Copy link
Owner Author

kliment commented Mar 14, 2022

If you know a way to do it, sure. I just didn't want to implement a markdown parser...

@rockstorm101
Copy link
Collaborator

Fair enough, I gave it some thinking and I couldn't figure out how to do it so I'm good with this as is.

@kliment kliment merged commit b276cab into master Mar 26, 2022
@rockstorm101 rockstorm101 deleted the update-credits branch January 23, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants