Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a check for maximun and minimun lower than 1 to prevent bad yAxis #412

Closed
wants to merge 1 commit into from
Closed

added a check for maximun and minimun lower than 1 to prevent bad yAxis #412

wants to merge 1 commit into from

Conversation

mawsyh
Copy link
Contributor

@mawsyh mawsyh commented Apr 13, 2023

https://github.com/liihuu/KLineChart/issues/409#issue-1665966438 for this bug they could add a precision or we can add this rule

@mawsyh mawsyh mentioned this pull request Apr 13, 2023
Closed
liihuu
liihuu reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@liihuu liihuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like this

@mawsyh mawsyh closed this Apr 14, 2023
@mawsyh mawsyh reopened this Apr 14, 2023
@mawsyh mawsyh closed this Apr 14, 2023
@mawsyh
Copy link
Contributor Author

mawsyh commented Apr 14, 2023

You are right using precession is probably a really better way to do it.
I just thought I could prevent adding 8 or 4 to the max value when max and min are both under 1

@mawsyh mawsyh deleted the yAxis_MaxMin_Lower1 branch April 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liihuu liihuu liihuu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mawsyh @liihuu