Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAB: magic number default values #150

Merged
merged 3 commits into from Jun 13, 2019
Merged

PAB: magic number default values #150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0af9d2a
PA: fixed version number in comment
klingo May 19, 2019
1bfdb57
PAB: replace hardcoded number with default value from Constants
klingo May 19, 2019
879a1ac
Merge branch 'master-v2' into PA-minor-fixes
klingo May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions PersonalAssistant/PersonalAssistantBanking/Menu/PABankingMenuFunctions.lua
View file
Open in desktop
Expand Up @@ -419,8 +419,8 @@ end
local function getPABankingAvaCrossAllianceItemIdBagAmountSetting(crossAllianceItemId)
if isDisabledPAGeneralNoProfileSelected() then return end
local value = PAB.SavedVars.AvA.CrossAllianceItemIds[crossAllianceItemId].bagAmount
-- in case a new GENERIC individual item is added, return "20" by default
if value then return value else return 20 end
-- in case a new GENERIC individual item is added, return the default value
if value then return value else return PAC.BACKPACK_AMOUNT.DEFAULT end
end

local function setPABankingAvaCrossAllianceItemIdBagAmountSetting(crossAllianceItemId, value)
Expand Down Expand Up @@ -477,8 +477,8 @@ end
local function getPABankingtAvAItemIdBagAmountSetting(itemId)
if isDisabledPAGeneralNoProfileSelected() then return end
local value = PAB.SavedVars.AvA.ItemIds[itemId].bagAmount
-- in case a new GENERIC individual item is added, return "20" by default
if value then return value else return 20 end
-- in case a new GENERIC individual item is added, return the default value
if value then return value else return PAC.BACKPACK_AMOUNT.DEFAULT end
end

local function setPABankingtAvAItemIdBagAmountSetting(itemId, value)
Expand Down