Putting space in does not create a "chip" for unknown contact

[tyczj]

If I put in and email address for someone that is not in my contact list there is no way to create a chip for that email.

In the gmail app for example if the email address is not in the contact list all you do is put a space in and it will create a chip for that address however putting in a space here does not do this and the only way to create a chip is to focus on something else.

Either that or do like the hangouts app does where you select the item from the Autocomplete list but as it stands this is broke.

I have not tried this with phone numbers so I do not know if that works correctly or not.

Edit:

I see that using a comma creates it but IMO you cannot expect the user to know this, use a comma or a space?

Edit 2:

I think I see the problem, in the method lastCharacterIsCommitCharacter of class RecipientEditTextView you do

return last == COMMIT_CHAR_COMMA || last == COMMIT_CHAR_SEMICOLON;

but you are missing COMMIT_CHAR_SPACE

[cargo8]

^ same exact problem, @tyczj did modifying the source with COMMIT_CHAR_SPACE fix the problem?

[tyczj]

@cargo8 I didnt try it yet

[legarspol]

@cargo8 @tyczj Tried. It works great :-)

[cargo8]

^ Yeah works quite well.

[timkoers]

Maybe close this issue so that any forker knows what's going on?

[bomiyr]

Hi,
It does not work again after this commit. Is there some big reason for that?

[cargo8]

@bomiyr seems as though it may be intentional. Certain use cases warrant a space as tokenization, others don't (i.e if the primary input will be full names that need to map to emails, you would want to be able to type the space as part of the match rather than tokenizing)

[KtodaZ]

Hey everyone, I created a custom solution for this, though I am only using phone numbers. Gist if anyone is interested: https://gist.github.com/KtodaZ/45c039abfcb208055f33e72e538e1124

[mandrachek]

I have this setup so that if the user denies contacts permission, I don't set an adapter, and if no adapter is present, then space is a separator, because the list is just straight up email addresses. If the adapter is present however, then contacts are used, and space is allowable in the context of a search.