-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Could accept an Parcelable on sendNewMessage() #126
Comments
This would be a great idea, definitely would help me a lot in making things easier, I might look into making a pull request for this |
amadeu01
added a commit
to amadeu01/android-smsmms
that referenced
this issue
Sep 5, 2018
@NickM-27 I did a PR for this, if you have the time, I would appreciate you having a look at it. |
@amadeu01 Looks good to me |
@klinker24 could you have a look at the PR? really thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be great to be possible to add extras to the
sentMessageIntent
anddeliveryIntents
So, one manner of doing that is by passing a
Parcelable
throughout the functions calls, and then the library could add them to their intents.Then I could be even easier to find out which SMS was sent we the
Receiver
is called. Once theParcelable
will come with the intent passed to theReceivers
android-smsmms/library/src/main/java/com/klinker/android/send_message/Transaction.java
Line 182 in a1a3f91
android-smsmms/library/src/main/java/com/klinker/android/send_message/Transaction.java
Line 118 in a1a3f91
The text was updated successfully, but these errors were encountered: