Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When receiving an MMS the current user address is always added to ADDR table #153

Open
L7ColWinters opened this issue Apr 9, 2019 · 2 comments

Comments

@L7ColWinters
Copy link

L7ColWinters commented Apr 9, 2019

After creating an MMS/SMS app myself for a few months we've run into issues where we have to query the mms table and we always get the current users phone number back in the list of addresses. I'm not sure why but in Klinker it's filtering the current user for when creating or getting the threadid but the address table is updated with all of the unfiltered addresses.

This logic is in PduPersister.loadRecipients

@L7ColWinters
Copy link
Author

Also i'm not sure if this is a big issue but it looks like were not checking the subscription id when checking the line1number so on dual sim phones the loadRecipients may not work properly.

@L7ColWinters
Copy link
Author

L7ColWinters commented Apr 9, 2019

After more thought, this would cause us to not know if it's a group message or not I believe, if we could know if it's a group than passing the addresses into the ADDR table would be unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant