Use right SMSManager object based on subscription id for downloading MMS #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klinker24
reviewed
Sep 4, 2019
|
@klinker24 When is the new library version expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading MMS in dual SIM cases may fail.
Example: User has two SIMs with subscription ids 1 & 2 say.
Current library always try to use default SMSManager for downloading MMS, which might fail if default subscription used is say 1 but actual MMS is received on 2.
I tested on Pulse SMS app, issue exist on Pulse SMS app as well.
Fix is to use SMS Manager based on subscription id of the received MMS, if id does not exist we fallback to using default.