-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linking curve plot axes #68
base: devel
Are you sure you want to change the base?
Conversation
Yes behaviour is slightly different, to what you had before: But I think new behavior is more proper. It introduces scrollbar when sublot is getting too narrow. On old version, if I was to add 10 plots, it would be unusable on FullHD monitor. You are right that scrolling is an issue - I didn't notice this. But this was also present without this change. If I reduce window height, scrollbar appears and scrolling issue is present: I could emulate the old behavior for now, but it doesn't seem like the best solution. It would be best to fix scrolling issue. Maybe page scrolling could be done only by means of dragging the slider and not by scrollwheel... Also related ocornut/imgui#7235 |
(cherry picked from commit 422562d364f06fd99441b60d9b3a6bc71efe762d)
I fixed with scroll issue by changing the plot flag. I think the only regression in this PR is that the bar plots are grouped at the bottom - not the same order as in the plot list. |
But even in the current version the order can be different if table type is used. I think matching the plot order with the plot list can be revisited in the future. I am quite happy with this change and what it enables. |
To be honest I don't really feel the need to show more than 4 or 5 plots at once. First point is that with five plots the acqusition might start to get laggy, the second one is that you can easily create a single plot dedicated to whatever you've got on the five plots you want to display at the moment. The solution you're proposing encourages to leave "garbage" plots on the viewport, thus reducing the app's performance. Moreover the Imgui/implot scrollbar is just not intutive - you have to find it on the right side, and if someone's new to the imgui ecosystem he/she might be lost. I'm really grateful for your input, but I just don't think its worth it - the axis linking is a bug, and I fully admit it, but at the same time it's not such a severe one that should make us introduce these changes (bar plot reordering, scroll bar appearing etc.). For now I'd wait for other people to give their opinion on this PR. |
Fixes #67
By separating curve subplots from bar subplots, curve plots axis linking can be set without being affected by bar plot axis limits.