Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go secrets #240

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Go secrets #240

merged 4 commits into from
Feb 21, 2023

Conversation

jhsinger-klotho
Copy link
Contributor

• Does any part of it require special attention?
• Does it relate to or fix any issue?

cutting this now to split the change to klotho::config out. That will follow, but for now this contains the following things.

Improvement to our args finding in go - I realized the old pattern would also catch nested args if one of the args was a call_expression node so we now make sure its a part of the same function call

updates FS to use the blob class so the user can choose between file blobs and mem blobs. This then allows them to pass in their own context since the blob.OpenBucket is what is used for s3 anyways.

Secrets support through runtimevar

the queries and tests to tie it all together

Standard checks

  • Unit tests: Any special considerations? theres a fair amount in here which should cover what we need
  • Docs: Do we need to update any docs, internal or public? not yet, we likely need polish and what not
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working? yeah go is new

@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 21%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 54%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 38%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 36%
github.com/klothoplatform/klotho/pkg/lang/javascript 48%
github.com/klothoplatform/klotho/pkg/lang/python 61%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 6%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 61%
github.com/klothoplatform/klotho/pkg/runtime 78%
github.com/klothoplatform/klotho/pkg/static_unit 33%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 41% (4033 / 9767)

@jhsinger-klotho jhsinger-klotho merged commit 573c219 into main Feb 21, 2023
@jhsinger-klotho jhsinger-klotho deleted the go-secrets branch February 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants