Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed input exception to temporary red innerHTML #58

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

joel-yap
Copy link
Collaborator

Should now display an error message above the searchboxes in red instead of a popup, goes away when the filter input is changed.

AdamN2424
AdamN2424 previously approved these changes Oct 17, 2023
Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Not sure how it will look on an actual mobile phone yet. Better than a popup IMO though.

@joel-yap
Copy link
Collaborator Author

Updated tests to match new reset alert function

Copy link
Collaborator

@RosieHall RosieHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joel-yap joel-yap merged commit 65a329a into master Oct 17, 2023
3 of 4 checks passed
@joel-yap joel-yap deleted the except-handling branch October 17, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants