Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge data branch #60

Merged
merged 17 commits into from
Oct 20, 2023
Merged

Merge data branch #60

merged 17 commits into from
Oct 20, 2023

Conversation

kloudsoft91
Copy link
Owner

closes #28

@kloudsoft91 kloudsoft91 linked an issue Oct 19, 2023 that may be closed by this pull request
Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues with your JSON data. Could you please go through each of your objects and match the format (and order for readability) so that it is exactly the same as the previous 15?
I know it's tedious but I did all 15 today and I can't do any more. Some issues I noticed: Missing fields: some have thickness_max but no min (this filter relies on both, so if you don't have a min just put 0).
cap_features.shape: need a field/value here (can't be null) most iNaturalist/wiki pages have the cap shape at the top of the species page. If it's out of the ordinary put "irregular".

Copy link
Collaborator

@AdamN2424 AdamN2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kloudsoft91 kloudsoft91 merged commit fbff2a2 into master Oct 20, 2023
1 of 4 checks passed
@kloudsoft91 kloudsoft91 deleted the merge-data-branch branch October 20, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up JSON
3 participants