fix: Fix zombie jinja2 processes

We missed calling Wait() on the process.
kluctl · May 30, 2022 · eda52d1 · eda52d1
1 parent f686192
commit eda52d1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/jinja2/jinja2_renderer.go b/pkg/jinja2/jinja2_renderer.go
@@ -13,6 +13,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"strings"
+	"time"
 )
 
 type pythonJinja2Renderer struct {
@@ -75,7 +76,11 @@ func (j *pythonJinja2Renderer) Close() {
 	}
 	if j.cmd != nil {
 		if j.cmd.Process != nil {
-			_ = j.cmd.Process.Kill()
+			timer := time.AfterFunc(5*time.Second, func() {
+				_ = j.cmd.Process.Kill()
+			})
+			_ = j.cmd.Wait()
+			timer.Stop()
 		}
 		j.cmd = nil
 	}