Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't perform version check in completion command #448

Merged
merged 1 commit into from Apr 29, 2023
Merged

fix: Don't perform version check in completion command #448

merged 1 commit into from Apr 29, 2023

Conversation

codablock
Copy link
Collaborator

Description

A version check while generating completion scripts or while performing completion is clearly not intended.

Fixes #447

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a new example

@codablock codablock merged commit a323315 into main Apr 29, 2023
4 checks passed
@codablock codablock deleted the fix-completion-version-check branch April 29, 2023 21:48
codablock added a commit that referenced this pull request May 12, 2023
@codablock
fix: Don't perform version check in completion command (#448)
f00f2d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not print version check when generating completions
1 participant
@codablock