fix: Take deployed CRDs into account when fixing namespaces #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a deployment also contains CRDs, the k8s client will not know if an object is namespaced before the CRD is actually applied. This leads to flaky behaviour between the initial and all other deployments. This commit delays fixing of namespaces until all objects are rendered. Then it takes CRDs into account when determining if an object is namespaced or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a deployment also contains CRDs, the k8s client will not know if an object is namespaced before the CRD is actually applied. This leads to flaky behaviour between the initial and all other deployments.
This commit delays fixing of namespaces until all objects are rendered. Then it takes CRDs into account when determining if an object is namespaced or not.
Type of change