Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Validation annotation #276

Closed
pauxus opened this issue May 31, 2023 · 1 comment · Fixed by #279
Closed

Drop Validation annotation #276

pauxus opened this issue May 31, 2023 · 1 comment · Fixed by #279

Comments

@pauxus
Copy link
Member

pauxus commented May 31, 2023 •
edited
Loading

Should be obsolete after #156, Validation.mode's purpose was to defer validation, which is now the default.
@pauxus pauxus changed the title Drop manualValidation Drop Validation(MANUAL) May 31, 2023
@pauxus
Copy link
Member Author

pauxus commented Jun 1, 2023

Once step further: since the only sensible use for @Validation is now @Validation(option=VALIDATE_UNMARKED) the whole annotation could be dropped and replaced by just allowing @Validate to be placed on classes as well.

@pauxus pauxus changed the title Drop Validation(MANUAL) Drop Validation annotation Jun 1, 2023
@pauxus pauxus linked a pull request Jun 2, 2023 that will close this issue
Feature/276 drop validation annotation #279
Merged
@pauxus pauxus mentioned this issue Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/276 drop validation annotation klum-dsl/klum-ast
1 participant
@pauxus