Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CopyFrom should always create deep copies? #36

Closed
pauxus opened this issue Dec 4, 2016 · 0 comments · Fixed by #259
Closed

CopyFrom should always create deep copies? #36

pauxus opened this issue Dec 4, 2016 · 0 comments · Fixed by #259
Projects
Klum Board
Milestone
2.0

Comments

@pauxus
Copy link
Member

pauxus commented Dec 4, 2016

See also #34

currently, copy already clones collections, but the elements themselves are not cloned. This might lead to unexpected behaviour.

Expected behaviour could be:

  • clone all clonable fields as well a all clonable collection/map members
  • clone only dsl objects

The clone method of a DSL object could itself be based on the copyFrom method.
@pauxus pauxus added this to the 1.2 milestone Apr 24, 2018
@pauxus pauxus modified the milestones: 1.2, 2.0 May 24, 2022
@pauxus pauxus added this to To do in Klum Board via automation May 26, 2022
@pauxus pauxus moved this from To do to In progress in Klum Board May 26, 2022
@pauxus pauxus mentioned this issue Jun 22, 2022
Merged
Klum Board automation moved this from In progress to Done Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Klum Board
  
Done
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Deep clones for templates and copyFrom klum-dsl/klum-ast
1 participant
@pauxus