Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation for GUI frontend #56

Closed
BaiqingL opened this issue Mar 23, 2020 · 6 comments
Closed

Adaptation for GUI frontend #56

BaiqingL opened this issue Mar 23, 2020 · 6 comments

Comments

@BaiqingL
Copy link

There seems to be quite a lot of code that could be removed and slimmed down. I am currently trying to write a Qt5 cross platform fronted for this project and it is taking a while to properly hook together things. In the future when this project evolves, the readability of the code base would be really important for further improvements. Can I suggest an effort to clean up the current code base before progressing to other things?

@BaiqingL
Copy link
Author

Nevermind, I was looking at a bunch of random code that doesn't seem to be used in any way. It's probably referenced and I just don't notice these things.

@klzgrad
Copy link
Owner

klzgrad commented Mar 25, 2020

It's a valid question. The current project structured is optimized for minimal maintenance, not minimal code size. You can check the list of files included: https://github.com/klzgrad/naiveproxy/blob/master/tools/include.txt.

It's possible to remove more unused code, but that will make the above list larger. Considering it's not a small list, I'd prefer not to do this kind of microoptimization.

As for the GUI there is one that I know of: https://github.com/ExcitedCodes/NaiveGUI.

It's possible to do it properly within the Chromium project structure. It contains everything you'll need to build a GUI. But for a third-party GUI the best is to use the binary as is.

@klzgrad klzgrad reopened this Mar 25, 2020
@klzgrad klzgrad changed the title [Request] Clean up codebase Adaptation for GUI frontend Mar 25, 2020
@KevinZonda
Copy link

KevinZonda commented Jun 7, 2020

I'm also developing a GUI client called NaiveSharp.

@BaiqingL
Copy link
Author

I'm also developing a GUI client called NaiveSharp.

Cool 😄!
Are there any plans to make it cross platform in the future?

@KevinZonda
Copy link

I'm also developing a GUI client called NaiveSharp.

Cool !
Are there any plans to make it cross platform in the future?

Exactly no. But you may be insterered in Qv2ray, it has naiveproxy plugin support and crossplatform.

@klzgrad
Copy link
Owner

klzgrad commented May 22, 2021

This issue can be merged into #158 now.

@klzgrad klzgrad closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants