Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naive: fix malformed http 1.0 request #539

Closed

Conversation

Chilledheart
Copy link
Contributor

HttpRequestHeaders::ToString not only has CRLR for every header, but also has the trailing CRLR.

It might affect POST/PUT methods.

  // Serializes HttpRequestHeaders to a string representation.  Joins all the
  // header keys and values with ": ", and inserts "\r\n" between each header
  // line, and adds the trailing "\r\n".
  std::string ToString() const;

@klzgrad
Copy link
Owner

klzgrad commented Aug 5, 2023

Separately fixed in master.

@klzgrad klzgrad closed this Aug 5, 2023
@Chilledheart Chilledheart deleted the fix_malform_http_1_0_request branch August 5, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants