refactor(compile): use async fns (#143) #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMalyugin
reviewed
Jun 29, 2023
| @@ -222,43 +222,42 @@ function generateTempFilename() { | |||
| ].join('')); | |||
| } | |||
|
|
|||
| function handleFileLoad(filename, callback) { | |||
| async function handleFileLoad(filename) { | |||
There was a problem hiding this comment.
Are you sure we can turn the entire system synchronous?
I'm concerned about this comment inside runner.js:
There was a problem hiding this comment.
The loader itself is still synchronous, which is why it makes the pipes synchronously. The function handling the load itself was always async, it just was async with callbacks. Now it's async with promises.
There was a problem hiding this comment.
Okay, I see, it was hybrid sync & async, since babel.transformFile is async.
And it doesn't really matter if we make parent process even more async, since runner is kept synchronous and is forced to wait for the synchronous pipe.
IMalyugin
reviewed
Jun 29, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @IMalyugin
Fixes Zalgo (function calling back with errors and/or synchronously throwing) issue as noted in #143 (comment)