Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore EPIPE on writeSync #38

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Ignore EPIPE on writeSync #38

merged 1 commit into from
Dec 27, 2016

Conversation

pfhayes
Copy link
Contributor

@pfhayes pfhayes commented Dec 23, 2016

No description provided.

@pfhayes pfhayes mentioned this pull request Dec 23, 2016
Closed
@pfhayes
Copy link
Contributor Author

pfhayes commented Dec 23, 2016

See #37

When we try to write to a closed pipe (which can happen after a restart) then the process dies. This allows us to be more resilient to this case

kmagiera
kmagiera approved these changes Dec 27, 2016
View reviewed changes
Copy link
Owner

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot for sending this PR! 👍

@kmagiera kmagiera merged commit 3b9f886 into kmagiera:master Dec 27, 2016
@kmagiera kmagiera mentioned this pull request Dec 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmagiera kmagiera kmagiera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pfhayes @kmagiera