Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backward compatible API typings #141

Merged
merged 3 commits into from Dec 6, 2018
Merged

Add backward compatible API typings #141

merged 3 commits into from Dec 6, 2018

Conversation

osdnk
Copy link
Contributor

@osdnk osdnk commented Dec 3, 2018 •
edited

Issue related: #138

@henrikra
Copy link

henrikra commented Dec 3, 2018

Looks good to me 👍

@henrikra
Copy link

henrikra commented Dec 5, 2018

Only thing I would change is backwardCompatibleWrapper => BackwardCompatibleWrapper. After that merge and publish?

@osdnk
Copy link
Contributor Author

osdnk commented Dec 6, 2018

nice, thanks @henrikra
ping @kmagiera

@kmagiera
Copy link
Member

kmagiera commented Dec 6, 2018

Thanks @henrikra for the review. And thanks @osdnk for this PR. Merging in

@kmagiera kmagiera merged commit bd19dee into master Dec 6, 2018
@kmagiera kmagiera deleted the fix-typings-backward-compatible branch December 6, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmagiera kmagiera kmagiera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@osdnk @henrikra @kmagiera