Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] "start" callback should be optional #209

Merged
merged 2 commits into from Mar 14, 2019
Merged

[TypeScript] "start" callback should be optional #209

merged 2 commits into from Mar 14, 2019

Conversation

itsjgf
Copy link
Contributor

@itsjgf itsjgf commented Mar 13, 2019

This PR allows using .start() without passing a callback to it (like Animated from react-native does 馃槄).

@itsjgf itsjgf changed the title fix(types): "start" callback should be optional [TypeScript] "start" callback should be optional Mar 13, 2019
Copy link
Contributor

@osdnk osdnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀 :shipit:

@osdnk osdnk merged commit 119953c into software-mansion:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants