Add SpringUtils.js #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
previously requested changes
Jul 19, 2018
There was a problem hiding this comment.
I'd prefer if we only allow a fixed structure to be accepted as a config. This could work if we expose helpers for creating state and config (similar to what we have in start/stop PR).
This should then be used in the following way:
const state = spring.makeState();
const config = spring.makeConfigFromOrigamiTensionAndFriction(0.5, 222);
spring(clock, state, config)
|
@kmagiera, Do you remember our offline discussion about this feature? |
…improvement # Conflicts: # README.md
osdnk
changed the title
osdnk
commented
Apr 25, 2019
| and, | ||
| greaterThan, | ||
| } from './../base'; | ||
| import AnimatedValue from './../core/InternalAnimatedValue'; |
There was a problem hiding this comment.
jkadamczyk
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/animations/SpringAnimation.js#L102
API known form RN core is much more flexible when it comes to being flexible.
We wanted to make using spring animation easier.
Changes
We didn't want to modify existing
springobject so I have addedSpringUtilsobject which is a set of methods for easier spring's config manipulations.