Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return new Observables instead of using compose with Transformers #21

Closed
kmdupr33 opened this issue May 6, 2017 · 1 comment
Closed

Comments

@kmdupr33
Copy link
Owner

kmdupr33 commented May 6, 2017

Current use of transformers is incorrect, as I'm not actually returning the result of applying a bunch of operators to an upstream Observable. This can result in weird behavior/race conditions if schedulers are used in certain ways (e.g., if the upstream observable emits on a background thread while the outer observable emits on the main thread). Since my current use doesn't fit the compose transformer contract, I probably shouldn't use it.

@kmdupr33 kmdupr33 closed this as completed May 6, 2017
@kmdupr33
Copy link
Owner Author

kmdupr33 commented May 6, 2017

I'm actually not 100% sure that this is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant